(6/308) 40 - CheckStyle package.html broken

Recreation Steps:
1. Configure the CheckStyle plug-in such that the Javadoc
package HTML is required:
checkstyle.require.packagehtml=yes
2. Check a buffer that doesn't have a package.html.

Nothing is reported to the Error List.

The problem is in CheckStyleThread.java, line 155. Here
the code is looking to strip off the postfix that was added
previously, but in this case, the file from the AuditEvent is
actually "package.html" instead of the source file. Since the
postfix isn't present in the file name, an
ArrayIndexOutOfBoundsException is thrown when calling
substring with -1.

An appropriate fix may be simply to do nothing if the postfix
wasn't found. The attached file has that fix.

Comments